Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Trainer.terminate_on_nan protected and deprecate public property #9849

Merged
merged 12 commits into from
Oct 12, 2021
Merged

Mark Trainer.terminate_on_nan protected and deprecate public property #9849

merged 12 commits into from
Oct 12, 2021

Conversation

ananthsub
Copy link
Contributor

@ananthsub ananthsub commented Oct 7, 2021 •
edited by awaelchli
Loading

What does this PR do?

Part of #8313
This is a follow up to #9848 and #9175 which should be merged before this

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@ananthsub ananthsub added the deprecation Includes a deprecation label Oct 7, 2021
@ananthsub ananthsub added this to the v1.5 milestone Oct 7, 2021
@ananthsub ananthsub mentioned this pull request Oct 7, 2021
Merged
12 tasks
@ananthsub ananthsub changed the title Deprecate terminate_on_nan Deprecate terminate_on_nan in Trainer Oct 7, 2021
@awaelchli awaelchli mentioned this pull request Oct 11, 2021
Merged
12 tasks
@awaelchli awaelchli reopened this Oct 11, 2021
@awaelchli awaelchli changed the title Deprecate terminate_on_nan in Trainer Mark Trainer.terminate_on_nan protected and deprecate public property Oct 11, 2021
@awaelchli
Copy link
Contributor

Hijacking this PR to finish what @ananthsub started here (he is on vacation) and updating with changes from master from recently merged #9175.

@awaelchli awaelchli marked this pull request as ready for review October 11, 2021 18:14
@awaelchli awaelchli self-assigned this Oct 11, 2021
tchaton
tchaton approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 12, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 12, 2021 19:50
@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

Merging #9849 (975976f) into master (173f4c8) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9849    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         178     178            
  Lines       15644   15658    +14     
=======================================
- Hits        14488   13907   -581     
- Misses       1156    1751   +595

@awaelchli awaelchli merged commit 4610fdd into Lightning-AI:master Oct 12, 2021
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
@ananthsub @awaelchli @rohitgr7
Mark Trainer.terminate_on_nan protected and deprecate public proper…
2dd6b97 
…ty (Lightning-AI#9849)

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@ananthsub ananthsub deleted the feat/deprecate-terminate-on-nan branch February 11, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 left review comments

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@awaelchli awaelchli

Labels
deprecation Includes a deprecation ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ananthsub @awaelchli @tchaton @rohitgr7 @kaushikb11